Skip to content

Small task, People and Activity fixes from the last organizations re-test - #1709

Merged
davidmckayv merged 8 commits into
mainfrom
fix/final-leftovers
Nov 16, 2026
Merged

davidmckayv merged 8 commits into
mainfrom
fix/final-leftovers

Conversation

@davidmckayv

Copy link
Copy Markdown
Contributor

Small faults the last re-test of organizations found in the app, each fixed with a test that failed before the fix.

  • A task's failure reason, said once. The task card says Couldn't finish; the reason and what to do about it are on the line reported under it.
  • Try again only where it can help. A task that couldn't finish because asking again gets the same answer (a Bot it asked isn't shared with the person, or the person lost this Bot) carries canTryAgain: false. The Needs you board then offers Open and Mark done, and names the state Couldn't finish, as the card does. A server that doesn't send the field still shows Try again.
  • A dismissed Request access. A task whose admin dismissed the app request it waited on says why under its result ("Couldn't finish · An admin didn't give this Bot Slack.") and its link no longer reads as done.
  • An answered request no longer says where. The needs-you line said "You answered this in its thread" when the answer came from the Bots page.
  • The Bots badge. Allow or Deny on the Needs you board now updates the sidebar badge at once.
  • People. The INITIAL_ADMIN_EMAILS line shows only on the first organization's People page. An organization's owner shows with the Admin switch on and not changeable, and Remove isn't offered for them.
  • Activity. A Bot's owner switching an app on or off for their own Bot reads "Give a Bot an app" and "Take an app from a Bot", not "Share an app".

Tests: task-thread, needs-you, bots-nav-badge, admin-people-remove, admin-people-roles, audit-event-words. Screens checked in Chromium and WebKit, light and dark, at 1440 and 700.

INITIAL_ADMIN_EMAILS names the admins of the deployment's first organization and of no other, but every organization's People page said "Addresses in INITIAL_ADMIN_EMAILS are always admins. You can't change them here." The line now shows only while the person is working in the first organization.

Test: admin-people-remove.test.tsx, the line shows in the first organization and not in another (shown in both before).
The needs-you line in the conversation that asked said "You answered this in its thread" even when the answer came from the Bots page's Needs you board. The card can't tell where the answer was given, so it no longer says.
Allow or Deny on the Needs you board left the sidebar badge on its old count until its next poll, seconds after the board showed the new one. Deciding an approval now reads the badge again at once, as answering a question already did.
…t can help

A task card in the conversation that asked repeated the reason its failure line under it already gives, with the next step. The card now says Couldn't finish and leaves the reason to that line.

Tasks gain canTryAgain: false when the task couldn't finish for a reason asking again gets the same answer to, such as a Bot it asked that isn't shared with the person. The Needs you board and the Activity rows then offer Open and Mark done, not Try again. The board also names the state as the card does, Couldn't finish, with the reason as its line.
With the reason said once, on the line a failed task reports, the card says only Couldn't finish. A task whose admin dismissed the Request access it waited on has no such line: its result was already said, with the app's card under it, and the result's link still read as done. The result now says why under its link ("Couldn't finish An admin didn't give this Bot Slack."), and the link reads as failed.

Test: task-thread.test.tsx, a result whose task then couldn't finish says why once and doesn't read as done (link read done, reason nowhere, before).
Activity named a Bot's owner switching an app on for their own Bot "Share an app", and off "Stop sharing an app". Nothing was shared with anybody. The rows now read "Give a Bot an app" and "Take an app from a Bot".

Test: audit-event-words.test.tsx, the owner's on and off rows read as giving and taking (Share an app before).
An owner's Admin switch read off and greyed: the switch read role === "admin", and an owner's role is owner. An owner governs the organization as an admin does, so the switch now reads on, and it can't be changed there, nor is Remove offered: only an owner gives ownership away, in Organization settings, and the server keeps the owner.

Test: admin-people-roles.test.tsx, an owner's switch reads on, can't be changed, and sends nothing (off before).
@davidmckayv
davidmckayv merged commit dd53aba into main Nov 16, 2026
16 checks passed
@davidmckayv
davidmckayv deleted the fix/final-leftovers branch November 16, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant